Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template the autoDiscovery.clusterName variable in the Helm chart #6189

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Template the autoDiscovery.clusterName variable in the Helm chart #6189

merged 1 commit into from
Nov 16, 2023

Conversation

mtougeron
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This allows templating of the autoDiscovery.clusterName parameter in the Helm chart so that you can do more dynamic processing of the cluster's name.

Which issue(s) this PR fixes:

Fixes # n/a

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Template the autoDiscovery.clusterName variable in the Helm chart

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/helm-charts labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2023
@mtougeron mtougeron force-pushed the tpl-clusterName-in-chart branch from bfe6ea6 to 3312382 Compare October 24, 2023 13:17
mwielgus
mwielgus approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 15, 2023
@mtougeron mtougeron force-pushed the tpl-clusterName-in-chart branch from 3312382 to 614c50a Compare November 15, 2023 14:47
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 15, 2023
@mtougeron
Copy link
Contributor Author

rebased to pickup the latest version change in the Chart.yaml

gjtempleton
gjtempleton reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@gjtempleton gjtempleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to also support it in the templating for CAPI?

autoscaler/charts/cluster-autoscaler/templates/_helpers.tpl

Line 119 in 6a7e6a2

{{- print "clusterName=" -}}{{ .Values.autoDiscovery.clusterName }}

Would also be good to add something to the readme explaining that this can be used I think?

charts/cluster-autoscaler/Chart.yaml Outdated
@@ -11,4 +11,4 @@ name: cluster-autoscaler
sources:
- https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler
type: application
version: 9.30.0
version: 9.30.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, going to need another version bump as merged #6194

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. :)

@mtougeron
Copy link
Contributor Author

Do we want to also support it in the templating for CAPI?

Yes I should update it there. I must have just missed that one. Thanks!

@mtougeron mtougeron force-pushed the tpl-clusterName-in-chart branch from 614c50a to 5b2380c Compare November 15, 2023 19:32
gjtempleton
gjtempleton reviewed Nov 16, 2023
View reviewed changes
charts/cluster-autoscaler/Chart.yaml Outdated
@@ -11,4 +11,4 @@ name: cluster-autoscaler
sources:
- https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler
type: application
version: 9.30.1
version: 9.30.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request actually, can we make this a minor version bump rather than a patch as we're adding functionality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mtougeron mtougeron force-pushed the tpl-clusterName-in-chart branch from 5b2380c to 841315f Compare November 16, 2023 22:08
@gjtempleton
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, mtougeron, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4eacea0 into kubernetes:master Nov 16, 2023
6 checks passed
@mtougeron mtougeron deleted the tpl-clusterName-in-chart branch December 19, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjtempleton gjtempleton gjtempleton left review comments

@mwielgus mwielgus mwielgus approved these changes

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@gjtempleton gjtempleton

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtougeron @gjtempleton @k8s-ci-robot @mwielgus